Python: Finalise change notes for 1.24.#3315
Conversation
|
@RasmusWL I may have missed something where the web libraries are concerned. Could you please check? 🙏 |
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Many thanks for finding the time to write this ✨ 🙇♀️
I've added a couple of comments/suggestions for things that stood out.
I also have some suggestions for lines 33-53. It may be simpler for me to raise a follow on PR instead of trying to comment on lines that haven't changed here. what's your preference?
Co-Authored-By: Felicity Chapman <felicitymay@github.com>
|
Thank you for the speedy review and for your suggestions! I am happy to accommodate whichever approach works best for you for reviewing lines 33-53. |
We don't hyphenate "QL-library" and there were a few typos. Feel free to further revise this if I've changed the meaning too much. As discussed separately, I was unable to raise this as a PR in GitHub.com and had to resort to a direct commit.
|
As discussed privately, I was unable to create a PR against your branch with my suggested changes to lines 33-52, so ended up making a direct commit. I will understand entirely if you need to revert some of those changes. |
|
I am happy with the changes you have made. Now we just need someone to approve this PR (I can't since I'm the author) and then we can merge it. |
|
I can't really approve now either. Presumably @RasmusWL has finished for the day? |
|
I think he should still be around. @BekaValentine is definitely around, so maybe we can get her to do it? 🙂 |
4 participants
cc: @felicitymay